Messages in this thread | | | Date | Wed, 5 Dec 2012 17:30:19 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH v7 2/3] aerdrv: Enhanced AER logging |
| |
On Wed, Dec 05, 2012 at 04:14:14PM +0000, Ortiz, Lance E wrote: > I removed the prefix argument because it was never used by its caller > and never set. The reason I added the prefix variable and set it to > NULL was to help in breaking up the patch and adding it would help the > intermittent patch build without changing too much code. I knew I was > actually going to use the variable in patch 3.
No, the correct way to do that is to keep all changes that belong logically together in a single patch for ease of reviewing and avoid breakages. And in your case this should be pretty easy: simply move all the 'prefix' touching code to patch #3 and you're done, AFAICT.
Thanks.
-- Regards/Gruss, Boris.
| |