lkml.org 
[lkml]   [2012]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 4/4 v6] iommu/fsl: Freescale PAMU driver and IOMMU API implementation.
Date


> -----Original Message-----
> From: Tabi Timur-B04825
> Sent: Tuesday, December 04, 2012 1:33 AM
> To: Sethi Varun-B16395
> Cc: joerg.roedel@amd.com; iommu@lists.linux-foundation.org; linuxppc-
> dev@lists.ozlabs.org; linux-kernel@vger.kernel.org; Wood Scott-B07421
> Subject: Re: [PATCH 4/4 v6] iommu/fsl: Freescale PAMU driver and IOMMU
> API implementation.
>
> Varun Sethi wrote:
>
> > + out_be32(&pamu_regs->ppbah, ((u64)ppaact_phys) >> 32);
> > + out_be32(&pamu_regs->ppbal, ppaact_phys);
> > + ppaact_phys = ppaact_phys + PAACT_SIZE;
> > + out_be32(&pamu_regs->pplah, ((u64)ppaact_phys) >> 32);
> > + out_be32(&pamu_regs->pplal, ppaact_phys);
>
> Instead of ((u64)ppaact_phys) >> 32, use upper_32_bits() and
> lower_32_bits().
>
> > +#define PAACE_NUMBER_ENTRIES 0xFF
>
> This is going to break with large LIODNs. Instead of hard-coding the
> size of the PPAACT, you need to scan the device tree for the largest
> LIODN, and make the array dynamically sized.
This would in any case change with the new LIODN allocation scheme. I intend on introducing the new scheme as a separate patch.

-Varun



\
 
 \ /
  Last update: 2012-12-05 11:02    [W:6.246 / U:0.804 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site