lkml.org 
[lkml]   [2012]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v6 2/3] aerdrv: Enhanced AER logging
Date
> > +	if (!dev) {
> > + pr_info("PCI AER Cannot get PCI device
> %04x:%02x:%02x.%d\n",
> > + pcie->device_id.segment, pcie->device_id.bus,
> > + pcie->device_id.slot, pcie->device_id.function);
>
> Hmm... please correct if I'm wrong, but an error happened at PCI, and
> also a
> kernel bug that prevented it to get the proper PCI device...
>
> IMHO, the message here should be stronger, and likely printed via
> pr_err().
>

Mauro,

I modeled this message after other places in the kernel where this function failed. So I figured it would be safe to be consistent there. I agree though that it should be pr_err(). I can make that change.


\
 
 \ /
  Last update: 2012-12-04 22:01    [W:0.039 / U:23.940 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site