Messages in this thread Patch in this message | | | From | Namjae Jeon <> | Subject | [PATCH 3/4] f2fs: fix removing cache entry within proper lock | Date | Sun, 30 Dec 2012 14:52:53 +0900 |
| |
From: Namjae Jeon <namjae.jeon@samsung.com>
Cache entry for free NID, is not getting removed under proper lock in case of error in add_free_nid. So, free the cache entry first before releasing the spinlock.
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com> Signed-off-by: Amit Sahrawat <a.sahrawat@samsung.com> --- fs/f2fs/node.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index 5066bfd..09139fb 100644 --- a/fs/f2fs/node.c +++ b/fs/f2fs/node.c @@ -1227,8 +1227,8 @@ retry: spin_lock(&nm_i->free_nid_list_lock); if (__lookup_free_nid_list(nid, &nm_i->free_nid_list)) { - spin_unlock(&nm_i->free_nid_list_lock); kmem_cache_free(free_nid_slab, i); + spin_unlock(&nm_i->free_nid_list_lock); return 0; } list_add_tail(&i->list, &nm_i->free_nid_list); -- 1.7.9.5
| |