Messages in this thread | | | Date | Mon, 3 Dec 2012 08:51:11 +0100 | From | "Hans J. Koch" <> | Subject | Re: [PATCH] uio.c: Fix warning: 'ret' might be used uninitialized |
| |
On Sat, Dec 01, 2012 at 09:58:32AM +0000, Cong Ding wrote: > If it is really necessary to save the 4 lines of codes, I would suggest to do > in the following style. But you are more senior than me, so I may be wrong in > this aspect.
"Seniority" (whatever you mean by that) has got nothing to do with it. I'll accept any child's patch if it is good. Discussing code on LKML is a purely technically thing, only if two patches are technically equivalent, the maintainer's personal taste will decide. And if it makes you feel better: My patches (and those of any other developer) are also sometimes rejected because they are not to some other maintainer's taste.
Thanks, Hans
| |