Messages in this thread | | | Date | Mon, 3 Dec 2012 14:01:04 -0500 | From | Aristeu Rozanski <> | Subject | Re: [PATCH 4/5] device_cgroup: make may_access() stronger |
| |
On Mon, Dec 03, 2012 at 09:44:14AM -0800, Tejun Heo wrote: > I kinda dislike this. This isn't a performanc critical path where we > must try our best to shave off a few condition checks. There's no > reason to encode the test like this. Please just spell the conditions > out in code rather than trying to build a magic series of equality > tests which somehow ends up spewing out the correct results.
sure, will do. but this is not "magic", that's just logic simplification.
-- Aristeu
| |