Messages in this thread | | | Date | Mon, 3 Dec 2012 09:04:21 -0800 | From | Dmitry Torokhov <> | Subject | Re: [PATCH v3 2/4] input: Cypress PS/2 Trackpad psmouse driver |
| |
On Mon, Dec 03, 2012 at 08:45:20AM +0100, Henrik Rydberg wrote: > > +/* > > + * reset trackpad device to standard relative mode. > > + * This is also the defalut mode when trackpad powered on. > > + */ > > +static void cypress_reset(struct psmouse *psmouse) > > +{ > > + struct cytp_data *cytp = psmouse->private; > > + > > + psmouse_reset(psmouse); > > + > > + CYTP_SET_MODE_BIT(CYTP_BIT_STANDARD_REL); > > + CYTP_SET_PACKET_SIZE(3); > > + > > + cytp->prev_contact_cnt = 0; > > +} > > I suppose it is, but is it necessary to reset to default mode?
It most likely is, as quite a few BIOSes get very upset and refuse to shutdown/suspend/resume if they find mouse (touchpad) in state other than bog-standard PS/2 mode. So psmouse_reset() is needed, the rest is not so much as the device supposed to be inactive from this point on.
Thanks.
-- Dmitry
| |