lkml.org 
[lkml]   [2012]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 061/173] ext4: init pagevec in ext4_da_block_invalidatepages
    3.2-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Eric Sandeen <sandeen@redhat.com>

    commit 66bea92c69477a75a5d37b9bfed5773c92a3c4b4 upstream.

    ext4_da_block_invalidatepages is missing a pagevec_init(),
    which means that pvec->cold contains random garbage.

    This affects whether the page goes to the front or
    back of the LRU when ->cold makes it to
    free_hot_cold_page()

    Reviewed-by: Lukas Czerner <lczerner@redhat.com>
    Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
    Signed-off-by: Eric Sandeen <sandeen@redhat.com>
    Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
    [bwh: Backported to 3.2: adjust context]
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    fs/ext4/inode.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/fs/ext4/inode.c
    +++ b/fs/ext4/inode.c
    @@ -1422,6 +1422,7 @@ static void ext4_da_block_invalidatepage

    index = mpd->first_page;
    end = mpd->next_page - 1;
    + pagevec_init(&pvec, 0);
    while (index <= end) {
    nr_pages = pagevec_lookup(&pvec, mapping, index, PAGEVEC_SIZE);
    if (nr_pages == 0)



    \
     
     \ /
      Last update: 2012-12-28 21:21    [W:4.107 / U:0.656 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site