lkml.org 
[lkml]   [2012]   [Dec]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/5] f2fs: Introduce some information prints in the mount path
From
2012/12/26, Joe Perches <joe@perches.com>:
> On Wed, 2012-12-26 at 11:10 +0900, Namjae Jeon wrote:
>> 2012/12/26, Jaegeuk Kim <jaegeuk.kim@samsung.com>:
>> > Hi,
>> Hi Jaegeuk.
>> >
>> > Could you make them follow the file system convention?
>> > Something like "F2FS: blah blah~".
>> Yes, I agree.
>>
>> >
>> > Otherwise, how about adding a debugging function to express the prefix?
>> Okay, I will send you the patches included your suggestion.
>
> Add
>
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>
> before any #include
Hi Joe.

I think we can have debugging message function for f2fs similar to
ext4/fat like fat_msg, ext4_msg.
It is one time change but in the future it will allow more convenience
to use that way.
What is your opinion ?

Or is that we have to to use pr_xxx function for error print instead
of own print debug function ?

Thanks.

>
>


\
 
 \ /
  Last update: 2012-12-26 05:41    [W:0.115 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site