lkml.org 
[lkml]   [2012]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mmc: omap_hsmmc: correct precedence of operators
On Thu, Dec 20, 2012 at 02:11:26PM -0500, Sasha Levin wrote:
> With the current code, the condition in the if() doesn't make much sense due to
> precedence of operators.
>
> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>

nice catch!!!

Acked-by: Felipe Balbi <balbi@ti.com>

> ---
> drivers/mmc/host/omap_hsmmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> index bc58078..3ee2664 100644
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
> @@ -611,7 +611,7 @@ static int omap_hsmmc_context_restore(struct omap_hsmmc_host *host)
> if (host->context_loss == context_loss)
> return 1;
>
> - if (!OMAP_HSMMC_READ(host->base, SYSSTATUS) & RESETDONE)
> + if (!(OMAP_HSMMC_READ(host->base, SYSSTATUS) & RESETDONE))
> return 1;
>
> if (host->pdata->controller_flags & OMAP_HSMMC_SUPPORTS_DUAL_VOLT) {
> --
> 1.8.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

--
balbi
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2012-12-20 22:01    [W:0.354 / U:2.848 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site