Messages in this thread | | | Date | Thu, 20 Dec 2012 10:13:54 +0900 | From | Joonyoung Shim <> | Subject | Re: [PATCH] gpio: samsung: remove exynos_gpio_cfg |
| |
Hi Grant,
On 12/20/2012 07:22 AM, Grant Likely wrote: > On Fri, 14 Dec 2012 19:44:01 +0900, Joonyoung Shim <jy0922.shim@samsung.com> wrote: >> The exynos_gpio_cfg can be substituted to samsung_gpio_cfgs[8]. >> >> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com> > Hi Joonyoung, > > I need some help here. I don't understand what this patch is for or how > it works. The commit text above doesn't give me enough information to > evaluate the patch. What is the intent here? Why is samsung_gpio_cfgs[8] > more correct than exynos_gpio_cfg?
First, i just wondered why samsung_gpio_cfgs[8] is used in the exynos4_gpios_2[] even if exynos_gpio_cfg is exist and found samsung_gpio_cfgs[8] does same thing with exynos_gpio_cfg. The exynos_gpio_cfg is used only for Exynos SoCs so it is compiled by #if defined(CONFIG_ARCH_EXYNOS4) || defined(CONFIG_ARCH_EXYNOS5). I think one can be removed because they are duplicated codes and it is better to decrease use of #if defined.
Thanks.
> g. > >
| |