Messages in this thread | | | Date | Wed, 19 Dec 2012 19:10:30 +0100 | From | Jens Axboe <> | Subject | Re: [boot crash] Re: [GIT PULL[ block drivers bits for 3.8 |
| |
On 2012-12-19 17:29, Linus Torvalds wrote: >> Of course it's been tested. Granted it got moved over too late (as 1 of >> 2 that did), but I've run the branch on a multitude of systems. >> Apparently none of them hit the case of having a zero granularity >> reported, so never hit the bug. > > I presumably happens on pretty much anything that doesn't have > discard. Of course, I've personally gotten rid of any rotating devices > I have, but it still sounds like there's a big testing hole somewhere.
It doesn't, though it seems so. Otherwise I definitely would have seen it. It only happens if discard max sectors is set, but alignment isn't. I suspect because that first divide is ordered after the !max_discard_sectors check. At least here.
And I suspect we would have seen a lot more reports if it DID trigger on anything that didn't have discard :-)
-- Jens Axboe
| |