Messages in this thread | | | From | Linus Torvalds <> | Date | Wed, 19 Dec 2012 08:29:25 -0800 | Subject | Re: [boot crash] Re: [GIT PULL[ block drivers bits for 3.8 |
| |
On Wed, Dec 19, 2012 at 6:47 AM, Jens Axboe <axboe@kernel.dk> wrote: > > It should all just be in sectors. The limits set are in bytes (could be > sectors too, but doesn't matter so much), but any interface operates in > sectors. > > I'm happy with your proposed fix. I think you should shove it in there, > then I'll make sure we get it cleaned up for 3.9.
Ok, committed and pushed out. Neil, can you please test it on whatever raid setting you can have?
In particular, it would be interesting to make sure it works correctly even without LBD support on 32-bit devices on partitions that start more than 4GB into the device, because that's the case I think was broken before.
> Of course it's been tested. Granted it got moved over too late (as 1 of > 2 that did), but I've run the branch on a multitude of systems. > Apparently none of them hit the case of having a zero granularity > reported, so never hit the bug.
I presumably happens on pretty much anything that doesn't have discard. Of course, I've personally gotten rid of any rotating devices I have, but it still sounds like there's a big testing hole somewhere.
Linus
| |