Messages in this thread | | | From | OGAWA Hirofumi <> | Subject | Re: [PATCH 1/1] fat:fix incorrect function comment | Date | Thu, 20 Dec 2012 00:57:24 +0900 |
| |
Ravishankar N <cyberax82@gmail.com> writes:
> /* > - * Return values: negative -> error, 0 -> not found, positive -> found, > - * value is the total amount of slots, including the shortname entry. > + * Return values: negative -> error/not found, 0 -> found. > */ > int fat_search_long(struct inode *inode, const unsigned char *name, > int name_len, struct fat_slot_info *sinfo) > @@ -1176,7 +1175,7 @@ static int fat_add_new_entries(struct inode *dir, void *slots, int nr_slots, > > /* > * The minimum cluster size is 512bytes, and maximum entry > - * size is 32*slots (672bytes). So, iff the cluster size is > + * size is 32*slots (672bytes). So, if the cluster size is
iff is right here. iff == if and only if
> -// fat_cache_add(inode, new_fclus, new_dclus);
I guess this still worth to keep as FIXME. This meant the following.
/* * FIXME: Although we can add this cache, fat_cache_add() is assuming to * be called after liner search with fat_cache_id. */
> } else { > MSDOS_I(inode)->i_start = new_dclus; > MSDOS_I(inode)->i_logstart = new_dclus;
Other parts looks fine.
Thanks. -- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
| |