Messages in this thread | | | Date | Tue, 18 Dec 2012 15:44:52 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH] cifs: Do not enable debugging code by default |
| |
On Tue, Dec 18, 2012 at 07:13:17AM -0500, Jeff Layton wrote: > I agree that we often need cifsFYI debug info in order to troubleshoot > problems. The question here though is whether compiling those in ought > to be the default. > > In generic distro kernels, I think we do want that turned on even in > non-debug kernels. On an embedded arch, it's less compelling. > > Might it make sense to couple this change with a change to the > CONFIG_CIFS_DEBUG help text? Something like: > > "This option defaults to 'N', but enabling this is strongly encouraged > unless memory is severely constrained."
... or we make it default n if EMBEDDED, otherwise default y + changing the help text?
> Then we can just try to make sure non-embedded distros enable it.
Yeah, I don't think distros look at the help text... or?
-- Regards/Gruss, Boris.
Sent from a fat crate under my desk. Formatting is fine. --
| |