Messages in this thread | | | Subject | Re: [PATCH 1/2] MCE, AMD: Make MC2 decoding part of amd_decoder_ops as well | From | Joe Perches <> | Date | Mon, 17 Dec 2012 12:34:35 -0800 |
| |
On Mon, 2012-12-17 at 21:22 +0100, Borislav Petkov wrote: > On Mon, Dec 17, 2012 at 12:16:16PM -0800, Joe Perches wrote: > > You also have paths where you start a pr_emerg and do not terminate it > > when there is no apparent error at all. > > For example? >
decode_mc2_mce does
pr_emerg(HW_ERR "MC2 Error: "); calls fam_ops->mc2_mce() which may not emit anything and if it doesn't, does pr_emerg(HW_ERR "Corrupted ..."); on another line leaving a trailing colon without newline from the pr_emerg above.
I believe the second pr_emerg should be pr_cont
cheers, Joe
| |