Messages in this thread | | | Date | Mon, 17 Dec 2012 09:38:15 +0200 | From | Sivaram Nair <> | Subject | Re: [PATCH 2/2] cpuidle: fix sysfs output for power_usage |
| |
On Sat, Dec 15, 2012 at 01:03:02AM +0100, Rafael J. Wysocki wrote: > On Friday, December 14, 2012 03:17:37 PM Sivaram Nair wrote: > > cpuidle_state->power_usage is signed; so change the corresponding sysfs > > ops to output signed value instead of unsigned. > > What's actually wrong with printing it as an unsigned int?
power_usage could have negative values (for example cpuidle/driver.c inits this value to -1, -2 etc. when drv->power_specified is not set) and these shows up badly in the sysfs output.
regards, Sivaram
| |