lkml.org 
[lkml]   [2012]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] arch/tile: implement user_regset interface on tilegx
On 12/14/2012 11:34 PM, Simon Marchi wrote:
> This is an implementation of user_regset for the tilegx architecture. It
> reuses the basic blocks that were already there.

Thanks, Simon! A couple of comments:

I encourage you to respin this for tilepro as well as tilegx, since it's going to be trivial to make it happen. Just take away all yours ifdefs, and use #include <arch/chip.h> and CHIP_ARCH_NAME instead of the string "tilegx". It's worth it just to avoid the ifdefs in the code :-)

I think with this support added, we have all the prerequisites to add "select HAVE_ARCH_TRACEHOOK" under "config TILE" in arch/tile/Kconfig, so we might as well do that too. That will enable PTRACE_GETREGSET and PTRACE_SETREGSET, as well as /proc/PID/syscall, so why not?

--
Chris Metcalf, Tilera Corp.
http://www.tilera.com



\
 
 \ /
  Last update: 2012-12-17 18:41    [W:0.064 / U:0.816 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site