Messages in this thread | | | From | Grant Likely <> | Subject | Re: [PATCH 2/2] spi: devicetree: add support for loopback mode | Date | Sun, 16 Dec 2012 21:14:14 +0000 |
| |
On Sat, 15 Dec 2012 16:55:46 +0200, Felipe Balbi <balbi@ti.com> wrote: > On Sat, Dec 15, 2012 at 12:32:24AM +0000, Grant Likely wrote: > > On Wed, 12 Dec 2012 10:46:00 +0200, Felipe Balbi <balbi@ti.com> wrote: > > > there are a few spi master drivers which make > > > use of that flag but there is no way to pass it > > > through devicetree. > > > > > > This patch just creates a way to pass SPI_LOOP > > > via devicetree. > > > > I don't understand how this would be useful since loopback mode is > > really just a test feature. Is there any reason to do loopback for > > something other than test? > > > > I think it would be better to add a sysfs or debugfs property to > > manipulate the SPI_LOOP flag from userspace. What do you think? > > might be nicer in the long run, indeed. Want me to look into it, or do > you wanna do it yourself ?
Yes, please look into it. After all, you're the one who needs the feature/ :-)
g.
| |