lkml.org 
[lkml]   [2012]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] time: create __getnstimeofday for WARNless calls
On 12/13/2012 10:17 AM, Kees Cook wrote:
> John, any feedback on this?
>
Sorry, yea, I've been meaning to get back to this.

I'm still on the fence about just making getnstimeofday() safe for when
timekeeping is suspended, but at the same time, your issue needs
fixing. Also bailing out at the end still seems off to me. Even if
someone is using the values despite the WARN_ON, they really are getting
junk values, and for all the time that WARN_ON has been there, you're
the first to report running into it.

Even so, I think I'm ok with this patch for now, but I suspect we may
want to rework it later.

Looking at my inbox, I actually can't find a copy of this specific
patch. Do you mind bouncing it to me, so I have something I can apply?

Should this also get marked for -stable?

thanks
-john



\
 
 \ /
  Last update: 2012-12-15 03:01    [W:0.071 / U:0.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site