lkml.org 
[lkml]   [2012]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] dmatest: check for dma mapping error
On Mon, 10 Dec 2012 13:37:44 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> We get a warning if CONFIG_DMA_API_DEBUG=y
>
> [ 28.150631] WARNING: at lib/dma-debug.c:933 check_unmap+0x5d6/0x6ac()
> [ 28.157058] dw_dmac dw_dmac.0: DMA-API: device driver failed to check map error[device address=0x0000000035698305] [size=14365 bytes] [mapped as single]
>
> ...
>
> --- a/drivers/dma/dmatest.c
> +++ b/drivers/dma/dmatest.c
> @@ -378,15 +378,35 @@ static int dmatest_func(void *data)
>
> dma_srcs[i] = dma_map_single(dev->dev, buf, len,
> DMA_TO_DEVICE);
> + ret = dma_mapping_error(dev->dev, dma_srcs[i]);
> + if (ret) {
> + unmap_src(dev->dev, dma_srcs, len, i);
> + pr_warn("%s: #%u: mapping error %d with "
> + "src_off=0x%x len=0x%x\n",
> + thread_name, total_tests - 1, ret,
> + src_off, len);
> + failed_tests++;
> + continue;
> + }

The changelog and the code don't match. Which one is out of date?


\
 
 \ /
  Last update: 2012-12-14 01:21    [W:0.120 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site