lkml.org 
[lkml]   [2012]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 205/241] ipv6: send unsolicited neighbour advertisements to all-nodes
    Date
    3.5.7.2 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Hannes Frederic Sowa <hannes@stressinduktion.org>

    commit 60713a0ca7fd6651b951cc1b4dbd528d1fc0281b upstream.

    As documented in RFC4861 (Neighbor Discovery for IP version 6) 7.2.6.,
    unsolicited neighbour advertisements should be sent to the all-nodes
    multicast address.

    Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com>
    ---
    net/ipv6/ndisc.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c
    index 54f62d3..35bfebc 100644
    --- a/net/ipv6/ndisc.c
    +++ b/net/ipv6/ndisc.c
    @@ -580,7 +580,7 @@ static void ndisc_send_unsol_na(struct net_device *dev)
    {
    struct inet6_dev *idev;
    struct inet6_ifaddr *ifa;
    - struct in6_addr mcaddr;
    + struct in6_addr mcaddr = IN6ADDR_LINKLOCAL_ALLNODES_INIT;

    idev = in6_dev_get(dev);
    if (!idev)
    @@ -588,7 +588,6 @@ static void ndisc_send_unsol_na(struct net_device *dev)

    read_lock_bh(&idev->lock);
    list_for_each_entry(ifa, &idev->addr_list, if_list) {
    - addrconf_addr_solict_mult(&ifa->addr, &mcaddr);
    ndisc_send_na(dev, NULL, &mcaddr, &ifa->addr,
    /*router=*/ !!idev->cnf.forwarding,
    /*solicited=*/ false, /*override=*/ true,
    --
    1.7.9.5


    \
     
     \ /
      Last update: 2012-12-13 16:01    [W:4.025 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site