lkml.org 
[lkml]   [2012]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/5] staging: omap-thermal: fix error check in omap_thermal_expose_sensor() and in omap_thermal_register_cpu_cooling().
    On 12-12-2012 02:24, Cyril Roelandt wrote:
    >
    > The omap_bandgap_get_sensor_data() function returns ERR_PTR(), so we need to use
    > IS_ERR() rather than a NULL check.
    >
    > Signed-off-by: Cyril Roelandt <tipecaml@gmail.com>

    Acked-by: Eduardo Valentin <eduardo.valentin@ti.com>

    > ---
    > drivers/staging/omap-thermal/omap-thermal-common.c | 4 ++--
    > 1 file changed, 2 insertions(+), 2 deletions(-)
    >
    > diff --git a/drivers/staging/omap-thermal/omap-thermal-common.c b/drivers/staging/omap-thermal/omap-thermal-common.c
    > index 61f1070..79a55aa 100644
    > --- a/drivers/staging/omap-thermal/omap-thermal-common.c
    > +++ b/drivers/staging/omap-thermal/omap-thermal-common.c
    > @@ -260,7 +260,7 @@ int omap_thermal_expose_sensor(struct omap_bandgap *bg_ptr, int id,
    >
    > data = omap_bandgap_get_sensor_data(bg_ptr, id);
    >
    > - if (!data)
    > + if (IS_ERR(data))
    > data = omap_thermal_build_data(bg_ptr, id);
    >
    > if (!data)
    > @@ -309,7 +309,7 @@ int omap_thermal_register_cpu_cooling(struct omap_bandgap *bg_ptr, int id)
    > struct omap_thermal_data *data;
    >
    > data = omap_bandgap_get_sensor_data(bg_ptr, id);
    > - if (!data)
    > + if (IS_ERR(data))
    > data = omap_thermal_build_data(bg_ptr, id);
    >
    > if (!data)
    >



    \
     
     \ /
      Last update: 2012-12-12 08:21    [W:3.981 / U:0.392 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site