Messages in this thread | | | Date | Tue, 11 Dec 2012 15:15:57 -0500 | Subject | Re: [PATCH 0/2] ima: policy search speedup | From | Eric Paris <> |
| |
On Tue, Dec 11, 2012 at 3:05 PM, Linus Torvalds <torvalds@linux-foundation.org> wrote:
> The "IS_PRIVATE()" thing is more a "if you know a-priori that you > aren't interested in pseudo-filesystems, you can already check that > bit, because it will be set for things like /proc and shmem mappings > and pipes etc".
I know it isn't relevant to the final solution, but this is simply wrong. IS_PRIVATE() means 'this inode is filesystem internal.' It is not used by anything except rieser and the anon_inode. If it is used by psuedo filesystems in general, like /proc, shmem mappings, and pipes that is a huge bug and is absolutely wrong.
You are correct IS_PRIVATE is sufficient to know you don't need to do any IMA stuff with that inode, but it is used in damn few places and better remain that way....
-Eric
| |