Messages in this thread | | | Date | Tue, 11 Dec 2012 21:20:39 +0800 | From | Shawn Guo <> | Subject | Re: [PATCH] clk: mxs: Remove unneeded NULL pointer check |
| |
On Tue, Dec 11, 2012 at 08:33:34AM -0200, Fabio Estevam wrote: > Shawn/Mike, > > On Wed, Nov 21, 2012 at 7:33 PM, Fabio Estevam <festevam@gmail.com> wrote: > > From: Fabio Estevam <fabio.estevam@freescale.com> > > > > mxs platform has been converted to device tree. > > > > There is no need to check if np is NULL after doing: > > > > np = of_find_compatible_node(NULL, NULL, "fsl,imx[23/28]-clkctrl"); > > > > ,as it will always be non-NULL. > > > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > > Does this patch look good?
Hmm, technically the check is still valid, as np can be NULL if the clkctrl node with correct compatible string is not present.
Shawn
| |