lkml.org 
[lkml]   [2012]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/5] virtio-scsi: create a separate workqueue
> patch 1-3,5 are some cleanups.
> patch 4: create a separate work queue for virtio-scsi
> to improve the performance, I tested with tmpfs backed
> disk, the config file is like below,

I think something else caused the improvement, because the code you
touched (complete_event) shouldn't ever run during a normal benchmark.
It's only used for hotplug/hot-unplug.

Nevertheless, I'll queue the cleanup patches. Thanks for those.

Paolo

> [global]
> bsrange=4k-64k
> ioengine=libaio
> direct=1
> iodepth=4
> loops=10
> size=64M
>
> Before:
> Disk stats (read/write):
> sda: ios=6547/5275, merge=37/39, ticks=3144/2645, in_queue=5780,
> util=81.62%
> sdb: ios=6542/5277, merge=54/59, ticks=3234/3143, in_queue=6364,
> util=84.50%
> sdc: ios=6532/5244, merge=65/62, ticks=3440/3076, in_queue=6505,
> util=86.83%
>
> After:
> Disk stats (read/write):
> sda: ios=6349/5318, merge=77/89, ticks=4820/3169, in_queue=7991,
> util=90.62%
> sdb: ios=6364/5358, merge=39/53, ticks=3810/2816, in_queue=6615,
> util=84.63%
> sdc: ios=6458/5352, merge=74/47, ticks=4425/3048, in_queue=7459,
> util=88.41%
>
>
> Wanlong Gao (5):
> virtio-scsi: remove the useless assignment
> virtio-scsi: remove the needless variable gfp_mask
> virtio-scsi: use pr_err instead of printk
> virtio-scsi: create a separate work queue for virtio-scsi
> virtio-scsi: tidy up the goto label in init()
>
>
>
> Cc: James E.J. Bottomley <JBottomley@parallels.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Rusty Russell <rusty@rustcorp.com.au>
> Cc: linux-scsi@vger.kernel.org
> Cc: kvm@vger.kernel.org
> drivers/scsi/virtio_scsi.c | 43
> +++++++++++++++++++++++--------------------
> 1 file changed, 23 insertions(+), 20 deletions(-)
>
> --
> 1.8.0
>
>


\
 
 \ /
  Last update: 2012-11-08 00:01    [W:0.060 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site