lkml.org 
[lkml]   [2012]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] add tpm_xenu.ko: Xen Virtual TPM frontend driver
> >>+static struct attribute *vtpm_attrs[] = {
> >>+ &dev_attr_pubek.attr,
> >>+ &dev_attr_pcrs.attr,
> >>+ &dev_attr_enabled.attr,
> >>+ &dev_attr_active.attr,
> >>+ &dev_attr_owned.attr,
> >>+ &dev_attr_temp_deactivated.attr,
> >>+ &dev_attr_caps.attr,
> >>+ &dev_attr_cancel.attr,
> >>+ NULL,
> >So are these going to show up in SysFS? If so, there should also be
> >a corresponding file in Documentation/.../sysfs/something.
> These are similar to the entries made by the other tpm drivers. I
> don't see any documentation about those either. TPM maintainers, any
> guidance there?

Yep, those show up in sysfs. I'll put docs on my todo list.

Kent

> >
> >>+#include "tpm.h"
> >>+#include "tpm_vtpm.h"
> >>+
> >>+#undef DEBUG
> >>+
> >>+#define GRANT_INVALID_REF 0
> >Interesting. The 0 grant value is actually a valid one. I think you
> >want (-1ULL).
> Is it?
> drivers/block/xen-blkfront.c and
> drivers/net/xen-netfront.c
>
> do the exact same thing
> >>+
> >>+ init_tpm_xenbus();
> >>+ return 0;
> >>+}
> >>+
> >>+
> >>+module_init(tpmif_init);
> >no module_exit?
> Will fix
>
>




\
 
 \ /
  Last update: 2012-11-07 16:41    [W:0.051 / U:0.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site