Messages in this thread | | | Date | Mon, 5 Nov 2012 20:08:47 +0200 | From | Mika Westerberg <> | Subject | Re: [PATCH 2/3] spi / ACPI: add ACPI enumeration support |
| |
On Mon, Nov 05, 2012 at 10:43:17AM -0700, Bjorn Helgaas wrote: > > It should already be unique in case of ACPI. We use ACPI _HID and _UID to > > achieve that. > > Using only _HID and _UID to guarantee uniqueness means you're relying > on a property of the BIOS, so you're vulnerable to BIOS bugs. > > If there's an ACPI Device for I2C adapters, why wouldn't you just use > its device name as set in acpi_device_register() (basically a _HID + > instance number)?
That's a good point - we could change to use that instead (the platform code in linux-pm tree uses _HID + _UID but I guess it is pretty trivial to change).
| |