lkml.org 
[lkml]   [2012]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH v9 20/34] vfs: allow utimensat() calls to retry once on an ESTALE error
Date
Clearly, we can't handle the NULL filename case, but we can deal with
the case where there's a real pathname.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
---
fs/utimes.c | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/fs/utimes.c b/fs/utimes.c
index bb0696a..c9ce931 100644
--- a/fs/utimes.c
+++ b/fs/utimes.c
@@ -154,17 +154,22 @@ long do_utimes(int dfd, const char __user *filename, struct timespec *times,
fdput(f);
} else {
struct path path;
- int lookup_flags = 0;
+ unsigned int lookup_flags = 0;
+ unsigned int try = 0;

if (!(flags & AT_SYMLINK_NOFOLLOW))
lookup_flags |= LOOKUP_FOLLOW;

- error = user_path_at(dfd, filename, lookup_flags, &path);
- if (error)
- goto out;
+ do {
+ error = user_path_at(dfd, filename,
+ lookup_flags, &path);
+ if (error)
+ break;

- error = utimes_common(&path, times);
- path_put(&path);
+ error = utimes_common(&path, times);
+ path_put(&path);
+ lookup_flags |= LOOKUP_REVAL;
+ } while (retry_estale(error, try++));
}

out:
--
1.7.11.7


\
 
 \ /
  Last update: 2012-11-05 17:21    [W:0.203 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site