Messages in this thread | | | Subject | Re: [PATCH] br2684: don't send frames on not-ready vcc | From | Nathan Williams <> | Date | Fri, 30 Nov 2012 12:18:05 +1100 |
| |
On Wed, 2012-11-28 at 17:09 +0000, David Woodhouse wrote: > On Wed, 2012-11-28 at 12:04 -0500, David Miller wrote: > > Do you want me to pull that tree into net-next or is there a plan to > > repost the entire series of work for a final submission? > > I think it needs a little more testing/consensus first. I'd like an ack > from Chas on the atm ->release_cb() thing, at least. And I wouldn't mind > confirmation from Nathan's customer that they're no longer seeing the > panics. >
The customer has confirmed that they haven't seen any panics. I tested these patches on OpenWrt with Kernel 3.3.8 and couldn't get a panic:
c118dc5 solos-pci: Fix leak of skb received for unknown vcc e539793 br2684: fix module_put() race 3656320 br2684: don't send frames on not-ready vcc 753f920 solos-pci: Wait for pending TX to complete when releasing vcc 91ab2cf pppoatm: do not inline pppoatm_may_send() 85b48fa pppoatm: drop frames to not-ready vcc 3ac1080 pppoatm: take ATM socket lock in pppoatm_send() e41faed pppoatm: fix module_put() race 3b1a914 pppoatm: allow assign only on a connected socket ec809bd atm: add owner of push() callback to atmvcc ae088d6 atm: br2684: Fix excessive queue bloat
I haven't tested these ones:
230a012 pppoatm: fix missing wakeup in pppoatm_send() 1c0c800 atm: Add release_cb() callback to vcc
| |