lkml.org 
[lkml]   [2012]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 01/18] perf evsel: Set leader evsel's ->leader to itself
    Date
    From: Namhyung Kim <namhyung.kim@lge.com>

    Currently only non-leader members are set ->leader to the leader evsel
    of the group and the leader has set NULL. Thus it requires special
    casing for leader evsels. Set ->leader to itself will remove this.

    Suggested-by: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Stephane Eranian <eranian@google.com>
    Signed-off-by: Namhyung Kim <namhyung@kernel.org>
    ---
    tools/perf/util/evlist.c | 1 -
    tools/perf/util/evsel.c | 1 +
    tools/perf/util/evsel.h | 2 +-
    3 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
    index 705293489e3c..90db2a14e4bb 100644
    --- a/tools/perf/util/evlist.c
    +++ b/tools/perf/util/evlist.c
    @@ -111,7 +111,6 @@ void __perf_evlist__set_leader(struct list_head *list)
    struct perf_evsel *evsel, *leader;

    leader = list_entry(list->next, struct perf_evsel, node);
    - leader->leader = NULL;

    list_for_each_entry(evsel, list, node) {
    if (evsel != leader)
    diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
    index 1fb636c550a1..ceabe05c6b12 100644
    --- a/tools/perf/util/evsel.c
    +++ b/tools/perf/util/evsel.c
    @@ -55,6 +55,7 @@ void perf_evsel__init(struct perf_evsel *evsel,
    {
    evsel->idx = idx;
    evsel->attr = *attr;
    + evsel->leader = evsel;
    INIT_LIST_HEAD(&evsel->node);
    hists__init(&evsel->hists);
    evsel->sample_size = __perf_evsel__sample_size(attr->sample_type);
    diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h
    index a4c1dd4e149f..d504668e7ae5 100644
    --- a/tools/perf/util/evsel.h
    +++ b/tools/perf/util/evsel.h
    @@ -228,6 +228,6 @@ static inline struct perf_evsel *perf_evsel__next(struct perf_evsel *evsel)

    static inline bool perf_evsel__is_group_member(const struct perf_evsel *evsel)
    {
    - return evsel->leader != NULL;
    + return evsel->leader != evsel;
    }
    #endif /* __PERF_EVSEL_H */
    --
    1.7.11.7


    \
     
     \ /
      Last update: 2012-11-29 08:21    [W:2.663 / U:1.472 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site