Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 26 Nov 2012 00:15:12 -0800 | From | Dmitry Torokhov <> | Subject | Re: [PATCH] HID: hidraw: fix nonblock read return EAGAIN after device removed |
| |
Hi Founder,
On Mon, Nov 26, 2012 at 10:30:37AM +0800, founder.fang wrote: > Hi Linux-Input, Jiri, Dmitry, > this patch is related to nonblock read on hidraw device. > when nonblock read the condition check (file->f_flags & O_NONBLOCK) > always be true, > signal_pending and device exist checking never get a chance to run, so > the user mode code always > get EAGAIN even if device removed. move nonblock mode checking to the > last can fix this problem. > > Signed-off-by: Founder Fang <founder.fang@gmail.com> >
Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Makes sense to me. However it looks like your mailer line-wrapped the patch, please resend so Jiri can apply it.
Thanks.
-- Dmitry
| ![\](/images/icornerr.gif) |