lkml.org 
[lkml]   [2012]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Fwd: [PATCH 1/7] I2c-nomadik: Fix the usage of wait_for_completion_timeout

> > - if (timeout < 0) {
> > - dev_err(&dev->adev->dev,
> > - "wait_for_completion_timeout "
> > - "returned %d waiting for event\n", timeout);
> > - status = timeout;
> > - }
> > -
> No, it is wrong. You need to update the status variable in the case of timeout.

Looking at the patch context, such code comes later.

--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2012-11-15 11:01    [W:0.154 / U:0.504 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site