Messages in this thread | | | Date | Tue, 13 Nov 2012 12:01:10 -0800 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH 21/46] x86, mm: setup page table in top-down |
| |
On 11/13/2012 11:59 AM, Yinghai Lu wrote: >> >> The changes to init_mem_mapping are a bit iffy but they aren't too >> unreasonable. >> Overall the patch is OK even though I would certainly appreciate more >> comments and better variable names (real_end?), see below. > > real_end is not good? > > xen put big reserved range between real_end and end. > > that real_end is some kind of end of real usable areas. > > so change to real_usable_end or usable_end? >
A description of a variable that includes the words "some kind of" clearly indicates major confusion. We need to know what the semantics are, here.
-hpa
| |