Messages in this thread | | | Date | Tue, 9 Oct 2012 14:46:17 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 2/3] lglock: make the per_cpu locks static |
| |
On Tue, 9 Oct 2012 11:46:39 +0800 Lai Jiangshan <laijs@cn.fujitsu.com> wrote:
> The per_cpu locks are not used outside nor exported. > Add a "static" linkage keyword to it.
I think a better description is:
: The per_cpu locks are not used outside the file which contains the : DEFINE_LGLOCK(), so we can make these symbols static.
> --- a/include/linux/lglock.h > +++ b/include/linux/lglock.h > @@ -49,7 +49,7 @@ struct lglock { > }; > > #define DEFINE_LGLOCK(name) \ > - DEFINE_PER_CPU(arch_spinlock_t, name ## _lock) \ > + static DEFINE_PER_CPU(arch_spinlock_t, name ## _lock) \ > = __ARCH_SPIN_LOCK_UNLOCKED; \ > struct lglock name = { .lock = &name ## _lock } > > -- > 1.7.4.4
| |