Messages in this thread | | | Date | Tue, 9 Oct 2012 18:29:25 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH] [RFC] pidns: don't zap processes several times |
| |
On 10/08, Andrey Wagin wrote: > > 2012/10/7 Oleg Nesterov <oleg@redhat.com>: > > > > Perhaps we should MAX_PID_NS_LEVEL instead? > > Yes, we can. > > Could I just define MAX_PID_NS_LEVEL in a code: > #define MAX_PID_NS_LEVEL ((PAGE_SIZE - offsetof(struct pid, numbers)) > / sizeof(struct upid))
Or even less. But looks reasonable.
> Or should it be added in a config?
Personally I think that "define" is fine, we can add config/sysctl later if needed.
Hmm. This is off-topic, but...
create_pid_namespace:
unsigned int level = parent_pid_ns->level + 1; ns->pid_cachep = create_pid_cachep(level + 1);
is it correct? is seems that only one "+ 1" is needed?
Oleg.
| |