Messages in this thread | | | Date | Tue, 9 Oct 2012 14:12:20 +0200 | From | Jean Delvare <> | Subject | Re: [PATCH 3/13] drivers/media/tuners/qt1010.c: use macros for i2c_msg initialization |
| |
Hi Julia,
On Mon, 8 Oct 2012 07:24:11 +0200 (CEST), Julia Lawall wrote: > > Sorry, I mean either: > > > > I2C_MSG_WRITE(priv->cfg->i2c_address, ®, sizeof(reg)), > > I2C_MSG_READ(priv->cfg->i2c_address, val, sizeof(*val)), > > Of course. Sorry for not having seen that. I can do that.
Eek, no, you can't, not in the general case at least. sizeof(*val) will return the size of the _first_ element of the destination buffer, which has nothing to do with the length of that buffer (which in turn might be rightfully longer than the read length for this specific message.)
-- Jean Delvare
| |