lkml.org 
[lkml]   [2012]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 07/12] perf kvm: handle realloc failures
Em Mon, Oct 08, 2012 at 11:17:31AM -0600, David Ahern escreveu:
> Save previous pointer and free on failure.

<SNIP>

> + prev = event->vcpu;
> event->vcpu = realloc(event->vcpu,
> event->max_vcpu * sizeof(*event->vcpu));
> if (!event->vcpu) {
> + free(prev);
> pr_err("Not enough memory\n");

Unfamiliar way of doing it, usually we do it like:

vcpu = realloc(event->vcpu, event->max_vcpu * sizeof(*event->vcpu));

if (!vcpu) {
pr_err("Not enough memory\n");
return -1;
}

event->vcpu = vcpu;

I.e. we don't trow away the old value of event->vcpu.

- Arnaldo


\
 
 \ /
  Last update: 2012-10-08 23:01    [W:0.173 / U:2.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site