lkml.org 
[lkml]   [2012]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/4] uprobes: Kill set_orig_insn()->is_swbp_at_addr()
* Oleg Nesterov <oleg@redhat.com> [2012-09-23 22:19:50]:

> Unlike set_swbp(), set_orig_insn()->is_swbp_at_addr() makes sense,
> although it can't prevent all confusions.
>
> But the usage of is_swbp_at_addr() is equally confusing, and it adds
> the extra get_user_pages() we can avoid.
>
> This patch removes set_orig_insn()->is_swbp_at_addr() but changes
> write_opcode() to do the necessary checks before replace_page().
>
> Perhaps it also makes sense to ensure PAGE_MAPPING_ANON in unregister
> case.
>
> find_active_uprobe() becomes the only user of is_swbp_at_addr(),
> we can change its semantics.
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
> ---



Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>



\
 
 \ /
  Last update: 2012-10-06 10:01    [W:2.467 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site