Messages in this thread | | | Date | Sat, 6 Oct 2012 12:48:08 +0530 | From | Srikar Dronamraju <> | Subject | Re: [PATCH 3/4] uprobes: Kill set_orig_insn()->is_swbp_at_addr() |
| |
* Oleg Nesterov <oleg@redhat.com> [2012-09-23 22:19:50]:
> Unlike set_swbp(), set_orig_insn()->is_swbp_at_addr() makes sense, > although it can't prevent all confusions. > > But the usage of is_swbp_at_addr() is equally confusing, and it adds > the extra get_user_pages() we can avoid. > > This patch removes set_orig_insn()->is_swbp_at_addr() but changes > write_opcode() to do the necessary checks before replace_page(). > > Perhaps it also makes sense to ensure PAGE_MAPPING_ANON in unregister > case. > > find_active_uprobe() becomes the only user of is_swbp_at_addr(), > we can change its semantics. > > Signed-off-by: Oleg Nesterov <oleg@redhat.com> > ---
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
| |