Messages in this thread | | | Date | Wed, 31 Oct 2012 22:23:42 +0100 | From | Michal Hocko <> | Subject | Re: [PATCH 1/8] cgroup: kill cgroup_subsys->__DEPRECATED_clear_css_refs |
| |
On Wed 31-10-12 13:14:07, Tejun Heo wrote: > Hey, Michal. > > On Wed, Oct 31, 2012 at 1:12 PM, Michal Hocko <mhocko@suse.cz> wrote: > > And sorry for being to annoying about this WARN_ON_ONCE but I really > > don't see any reason for it. pre_destroy can still happen and now it is > > even reduced to a reasonable condition (somebody shown up). So I would > > put it out of way as it doesn't give us anything and as I've already > > mentioned one can trigger it really easily. > > It was there before and goes away in several commits. I have to > explain all that to remove it in this patch. Why do that when the > whole thing is just gonna disappear anyway?
I would consider it nicer but if you feel it is not worth it then don't worry. It is not a big deal. The important part is that we do not ignore the return value now.
Thanks -- Michal Hocko SUSE Labs
| |