Messages in this thread | | | Date | Thu, 4 Oct 2012 03:51:22 +0200 | From | Andi Kleen <> | Subject | Re: [GIT PULL v2] Update LZO compression |
| |
> > > - Post the entire patch series to lkml for review (I'd like a cc please) > > > > Already happened, multiple people reviewed and tested. > > um, I would not consider "Looks ok to me from a quick look." and "I > couldn't tell from the github view, but I assume you follow standard > coding style." to indicate a rigorous code review!
Let's put it like this. LZO is mature widely used production software and Markus wrote and maintains it. Essentially this is a release from him.
The main problem before with using his version directly was that it did not follow Linux coding standards, but that seems to be fixed now. It's also relatively simple and at least I didn't spot anything bad when I looked.
It was runtime tested by several people on different architectures. If it was fuzzed so we can assume reasonably good security.
-Andi
-- ak@linux.intel.com -- Speaking for myself only.
| |