lkml.org 
[lkml]   [2012]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v3 7/7] Add a format check for an existing variable name at erasing time
Date
> > +                                 utf16_strlen(efi_name))) {
> > + /*
> > + * Check if an old format,
> > + * which doesn't support holding
> > + * multiple logs, remains.
> > + */
> > + if (sscanf(name, "dump-type%u-%u-%lu",
> > + &type_old, &part_old, &time_old) !=
> > + 3)
>
> This doesn't look right. This should probably mirror the sprintf() at the top of the function using a new string, convert it to 16-bit
> Unicodeand then compare it like we do for the 4-variable version above (please ignore the fact that this driver incorrectly calls these
> strings utf16 everywhere -- that needs to be fixed).

I will fix it as well.

Seiji


\
 
 \ /
  Last update: 2012-10-30 00:21    [W:0.043 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site