Messages in this thread | | | From | Seiji Aguchi <> | Subject | RE: [PATCH v3 7/7] Add a format check for an existing variable name at erasing time | Date | Mon, 29 Oct 2012 20:40:59 +0000 |
| |
> > + utf16_strlen(efi_name))) { > > + /* > > + * Check if an old format, > > + * which doesn't support holding > > + * multiple logs, remains. > > + */ > > + if (sscanf(name, "dump-type%u-%u-%lu", > > + &type_old, &part_old, &time_old) != > > + 3) > > This doesn't look right. This should probably mirror the sprintf() at the top of the function using a new string, convert it to 16-bit > Unicodeand then compare it like we do for the 4-variable version above (please ignore the fact that this driver incorrectly calls these > strings utf16 everywhere -- that needs to be fixed).
I will fix it as well.
Seiji
| |