Messages in this thread Patch in this message | | | Subject | [PATCH v2] checkpatch: Warn on unnecessary line continuations | From | Joe Perches <> | Date | Sat, 27 Oct 2012 21:46:36 -0700 |
| |
When the previous line is not a line continuation and the current line has a line continuation but is not a #define, emit a warning.
Signed-off-by: Joe Perches <joe@perches.com> --- scripts/checkpatch.pl | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index f18750e..d4f61a6 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3013,6 +3013,15 @@ sub process { "Macros with complex values should be enclosed in parenthesis\n" . "$herectx"); } } + +# check for line continuations outside of #defines + + } else { + if ($prevline !~ /^..*\\$/ && + $line =~ /^\+.*\\$/) { + WARN("LINE_CONTINUATIONS", + "Avoid unnecessary line continuations\n" . $herecurr); + } } # do {} while (0) macro tests:
| |