lkml.org 
[lkml]   [2012]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 10/31] mm/mpol: Remove NUMA_INTERLEAVE_HIT

* Andi Kleen <andi@firstfloor.org> wrote:

> Peter Zijlstra <a.p.zijlstra@chello.nl> writes:
>
> > Since the NUMA_INTERLEAVE_HIT statistic is useless on its
> > own; it wants to be compared to either a total of interleave
> > allocations or to a miss count, remove it.
> >
> > Fixing it would be possible, but since we've gone years
> > without these statistics I figure we can continue that way.
> >
> > Also NUMA_HIT fully includes NUMA_INTERLEAVE_HIT so users
> > might switch to using that.
> >
> > This cleans up some of the weird MPOL_INTERLEAVE allocation
> > exceptions.
>
> NACK, as already posted several times.
>
> This breaks the numactl test suite, which is the only way
> currently to test interleaving.

This patch is not essential to the NUMA series so I've zapped it
from the patch queue and fixed up the roll-on effects.

Thanks,

Ingo


\
 
 \ /
  Last update: 2012-10-26 10:41    [W:0.091 / U:0.924 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site