Messages in this thread | | | Date | Fri, 26 Oct 2012 10:21:41 -0700 | From | Tony Lindgren <> | Subject | Re: [PATCH v2 3/3] ARM: OMAP: ocp2scp: create omap device for ocp2scp |
| |
* Arnd Bergmann <arnd@arndb.de> [121026 00:48]: > On Friday 26 October 2012, Felipe Balbi wrote: > > > +static void omap_init_ocp2scp(void) > > > +{ > > > + struct omap_hwmod *oh; > > > + struct platform_device *pdev; > > > + int bus_id = -1, dev_cnt = 0, i; > > > + struct omap_ocp2scp_dev *ocp2scp_dev; > > > + const char *oh_name, *name; > > > + struct omap_ocp2scp_platform_data *pdata; > > > + > > > + oh_name = "ocp2scp_usb_phy"; > > > + name = "omap-ocp2scp"; > > > > how about adding checks here to return early case we're not running on > > OMAP4 or OMAP5 ?? > > > > I suppose even OMAP4-only, since OMAP5 always has DT enabled.
Hmm yes, currently omap_hwmod_lookup(oh_name) produces bogus errors for other omaps as the hwmod data is only there for omap4.
Regards,
Tony
| |