Messages in this thread | | | Date | Wed, 24 Oct 2012 11:28:20 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: irq/manage.c wrong comment( ? ) |
| |
On Sun, 21 Oct 2012, anish kumar wrote:
> ping...
Oh well.
> On Sat, 2012-10-13 at 00:32 +0900, anish kumar wrote:? > > Hello tglx, > > > > I just found the below inconsistency while going through the code. > > > > > > kernel/irq/manage.c > > > > if (new->flags & IRQF_ONESHOT) { > > /* > > * The thread_mask for the action is or'ed to > > * desc->thread_active to indicate that the > > * IRQF_ONESHOT thread handler has been woken, but not > > * yet finished. The bit is cleared when a thread > > * completes. When all threads of a shared interr > > > > Shouldn't this "desc->thread_active" be desc->threads_active ??
That's obvious, right? Please send a proper patch if you think it's really that important.
Thanks,
tglx
| |