lkml.org 
[lkml]   [2012]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH V3] PWM: Add SPEAr PWM chip driver support
From
On 22 October 2012 13:25, Thierry Reding
<thierry.reding@avionic-design.de> wrote:
> We could probably do that in the core. I've had some discussions about
> this with Lars-Peter (Cc'ed) who also had doubts about how this is
> currently handled.
>
> What you're proposing is different, however. If we put that code in the
> core it will mean that once the module is unloaded, all PWM devices will
> be disabled. There is currently code in the core that prevents the chip
> from being removed if one or more PWM devices are busy. But as explained
> above, with the current core code this return value isn't useful at all.

This is what many drivers in pwm framework are doing currently too..
They disable
pwm and its clock and then do chip remove.

Sorry, i didn't get the conclusion completely :(
Should we keep code suggested by me in core or spear's driver?

--
viresh


\
 
 \ /
  Last update: 2012-10-22 11:01    [W:1.467 / U:0.768 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site