Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCHv7 2/4] virtio_console: Use kmalloc instead of kzalloc | Date | Tue, 23 Oct 2012 12:06:34 +1030 |
| |
sjur.brandeland@stericsson.com writes:
> From: Sjur Brændeland <sjur.brandeland@stericsson.com> > > Avoid the more cpu expensive kzalloc when allocating buffers. > Originally kzalloc was intended for isolating the guest from > the host by not sending random guest data to the host. But device > isolation is not yet in place so kzalloc is not really needed. > > Signed-off-by: Sjur Brændeland <sjur.brandeland@stericsson.com>
This looks fine to me. This is *why* the device gives us the length which was written; we can trust that, even if we can't trust the writer of data.
(In theory: noone has implemented such a system, yet).
Applied. Rusty.
> diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c > index c36b2f6..301d17e 100644 > --- a/drivers/char/virtio_console.c > +++ b/drivers/char/virtio_console.c > @@ -349,7 +349,7 @@ static struct port_buffer *alloc_buf(size_t buf_size) > buf = kmalloc(sizeof(*buf), GFP_KERNEL); > if (!buf) > goto fail; > - buf->buf = kzalloc(buf_size, GFP_KERNEL); > + buf->buf = kmalloc(buf_size, GFP_KERNEL); > if (!buf->buf) > goto free_buf; > buf->len = 0; > -- > 1.7.5.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |