lkml.org 
[lkml]   [2012]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/5] IPMI: Fix some uninitialized warning
On Tue, 16 Oct 2012 15:53:39 -0500
minyard@acm.org wrote:

> From: Corey Minyard <cminyard@mvista.com>
>
> There was a spot where the compiler couldn't tell some variables
> would be set. So initialize them to make the warning go away.
>
> Signed-off-by: Corey Minyard <cminyard@mvista.com>
> ---
> drivers/char/ipmi/ipmi_msghandler.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
> index 2c29942..a0c84bb 100644
> --- a/drivers/char/ipmi/ipmi_msghandler.c
> +++ b/drivers/char/ipmi/ipmi_msghandler.c
> @@ -1880,7 +1880,7 @@ int ipmi_request_supply_msgs(ipmi_user_t user,
> struct ipmi_recv_msg *supplied_recv,
> int priority)
> {
> - unsigned char saddr, lun;
> + unsigned char saddr = 0, lun = 0;
> int rv;
>
> if (!user)

The kernel build actually generates quite a lot of "bar uninitialised"
warnings for foo(&bar) expressions. I just ignore them, because later
versions of gcc stopped doing that.

The fix is OK, I suppose. But it will cause additional code to be
emitted. Using uninitialized_var() avoids that, and makes things
clearer to the reader.


\
 
 \ /
  Last update: 2012-10-23 02:21    [W:0.647 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site