Messages in this thread | | | Date | Mon, 22 Oct 2012 13:02:12 -0700 | From | Greg KH <> | Subject | Re: [PATCH] Staging: android: binder: Fixed multi-line strings |
| |
On Mon, Oct 08, 2012 at 04:15:14PM -0700, Joe Perches wrote: > On Tue, 2012-10-09 at 00:31 +0530, Anmol Sarma wrote: > > Changed all user visible multi-line stings to single line. > > Another patch might be to add > > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > before any #include and > > > diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c > [] > > @@ -556,8 +556,8 @@ static int binder_update_page_range(struct binder_proc *proc, int allocate, > > goto free_range; > > > > if (vma == NULL) { > > - pr_err("binder: %d: binder_alloc_buf failed to " > > - "map pages in userspace, no vma\n", proc->pid); > > + pr_err("binder: %d: binder_alloc_buf failed to map pages in userspace, no vma\n", > > + proc->pid); > > remove all the "binder: " prefixes like: > > pr_err("%d: binder_alloc_buf failed to map pages in userspace, no vma\n", > proc->pid);
Yes, that would be the better fix.
Anmol, care to redo this patch that way?
thanks,
greg k-h
| |